[FIX] connector_woocommerce: expected string or bytes-like object whe…

…n export product without description
nuobit · Oct 10, 2024 · 189b440 · 189b440
1 parent 0a02890
commit 189b440
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 15 deletions.
diff --git a/connector_woocommerce/models/product_product/export_mapper.py b/connector_woocommerce/models/product_product/export_mapper.py
@@ -97,11 +97,15 @@ def stock(self, record):
         return stock
 
     def _get_product_description(self, record):
-        return tools.color_rgb2hex(
-            record.with_context(
-                lang=self.backend_record.language_id.code
-            ).variant_public_description
-        )
+        description = record.with_context(
+            lang=self.backend_record.language_id.code
+        ).variant_public_description
+        if not description:
+            raise ValidationError(
+                _("The product variant {%s} has no variant public description.")
+                % record.display_name
+            )
+        return tools.color_rgb2hex(description)
 
     @mapping
     def description(self, record):

diff --git a/connector_woocommerce/models/product_template/export_mapper.py b/connector_woocommerce/models/product_template/export_mapper.py
@@ -110,18 +110,26 @@ def sale_price(self, record):
         return {"sale_price": None}
 
     def _get_product_description(self, record):
-        return tools.color_rgb2hex(
-            record.record.with_context(
-                lang=self.backend_record.language_id.code
-            ).public_description
-        )
+        description = record.with_context(
+            lang=self.backend_record.language_id.code
+        ).public_description
+        if not description:
+            raise ValidationError(
+                _("The product template %s has no public description")
+                % record.display_name
+            )
+        return tools.color_rgb2hex(description)
 
     def _get_product_variant_description(self, record):
-        return tools.color_rgb2hex(
-            record.product_variant_id.with_context(
-                lang=self.backend_record.language_id.code
-            ).variant_public_description
-        )
+        description = record.product_variant_id.with_context(
+            lang=self.backend_record.language_id.code
+        ).variant_public_description
+        if not description:
+            raise ValidationError(
+                _("The product template %s has no variant public description")
+                % record.display_name
+            )
+        return tools.color_rgb2hex(description)
 
     @mapping
     def description(self, record):