Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent appending configuration if configuration flag is set #306

Open
wants to merge 1 commit into
base: v8.x
Choose a base branch
from

Conversation

oceanapplications
Copy link

In reference to this bug

laravel/framework#51207

@oceanapplications
Copy link
Author

Can we get this merged soon? The bug causes CI/CD failures which is super annoying.

@piurafunk
Copy link

piurafunk commented Oct 2, 2024

This is also now impacting my team, as we upgrade to Laravel 11.x. Our CI pipeline has its own phpunit.xml.ci configuration. Previous versions of PHPUnit allowed multiple declarations and it worked, but it felt more like it happened to work rather than it was designed to work that way. PHPUnit now specifically disallows setting it multiple times.

@oceanapplications
Copy link
Author

This is also now impacting my team, as we upgrade to Laravel 11.x. Our CI pipeline has it sown phpunit.xml.ci configuration. Previous versions of PHPUnit allowed multiple declarations and it worked, but it felt more like it happened to work rather than it was designed to work that way. PHPUnit now specifically disallows setting it multiple times.

I had to switch to my fixed branch to continue CI without this error. Been months without being merged.

@xam-ps
Copy link

xam-ps commented Oct 13, 2024

@nunomaduro any plan to merge this anytime soon? My pipeline tests are "broken" for about 5 months now even though they are all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants