Various fixes to get pad mode working #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In class modes.pad.PadMode: * Removed fractional part of octave_offset when calculating note_value * Truncate note_value to integer Also: buttons.pad.PadButton.send_color_direct() * Ensure we don't access scolor[3] if length < 4 modes.drum.DrumPad.send_color() * Ensure we don't call _button.send_color_direct() when _button is None object
* Fixed issue of (some) drum racks not being recognized as containing drum pads * Modify modes._base.find_drum_device() to use find_drum_group_device() which also searches through device chains * modes.drum.DrumMode.assign_pads(): * Fix indentation which could cause final for loop to be skipped * Added pad._button is not None checks * Added MonoNavSection.MonoNavSection._set_mode() so that button (light on/off) reflects intial state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In class modes.pad.PadMode:
Also:
buttons.pad.PadButton.send_color_direct()
modes.drum.DrumPad.send_color()