Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connectors): add mocks test update scripts #801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

douglasduteil
Copy link
Member

@douglasduteil douglasduteil commented Oct 29, 2024


npm run test:update-mocks

I propose a mocks update script.
I think we should do better that this by using test snapshot be here is a example of how one can maintain the mocks

Requires #800 to work !

@douglasduteil douglasduteil marked this pull request as draft October 30, 2024 06:56
@douglasduteil douglasduteil force-pushed the douglasduteil/test-connectors-add-mocks-test-update-scripts branch from 9780c03 to 07791ac Compare October 30, 2024 10:41
@douglasduteil douglasduteil marked this pull request as ready for review October 30, 2024 10:42
Copy link
Contributor

@rdubigny rdubigny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait ajouter les 6 fichiers json manquants pour éviter le lava-flow antipattern

@@ -26,6 +26,7 @@
"test:lint": "prettier '**/*.ts' --list-different",
"test:type-check": "tsc --noEmit",
"test:unit": "NODE_ENV=test mocha --require tsx test/*.ts",
"test:update-mocks": "UPDATE_MOCKS=true mocha --require tsx test/api-annuaire-service-public-data/*.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update-mocks

@douglasduteil douglasduteil self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants