Multiple corrections sur le DSFR #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, je croyais que Django 3 était plus supporté ? Comment #168 a pu même passer ? |
christophehenry
force-pushed
the
che/multiple-fixes
branch
2 times, most recently
from
db7454e to
c5f55bf
Compare
|
Le support de Django 3 doit être retiré dans la prochaine version (cf. le README) |
|
Je comprends pas comment les tests ont pu passer. Cette ligne ne fonctionne pas dans Django 3. Edit : voilà normalement, c'est réparé. |
christophehenry
force-pushed
the
che/multiple-fixes
branch
2 times, most recently
from
35e28d8 to
bbfbb24
Compare
- Simplify form_field_snippets templates by setting 'aria-describedby' in dsfr_input_class_attr filter - Don't use 'field.label_tag' when specifying <label> or <legend> - Add support inline checkboxes and radio buttons - Add ability to inline fields with new 'dsfr_inline' filter
christophehenry
force-pushed
the
che/multiple-fixes
branch
from
bbfbb24 to
5c7efae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
form_field_snippetsen définissantaria-describedbydans le filtredsfr_input_class_attrfield.label_tagparfield.labellorsque<label>ou<legend>sont explicitement utilisés dans le template (ça provoquait l'imbrication d'un<label>dans un<label>ou<legend>)dsfr_inline.checkboxselectmultiple_snippet.htmletradioselect_snippet.htmlpour être cohérent avec la documentation DSFR.