Diverging recommmandations between W3C and audit >_>

numerique-gouv · Apr 18, 2022 · 9eb0182 · 9eb0182
1 parent e20452f
commit 9eb0182
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 13 deletions.
diff --git a/dsfr/templates/dsfr/breadcrumb.html b/dsfr/templates/dsfr/breadcrumb.html
@@ -1,4 +1,4 @@
-<nav class="fr-breadcrumb" aria-label="vous êtes ici :">
+<nav role="navigation" class="fr-breadcrumb" aria-label="vous êtes ici :">
     <button type="button" class="fr-breadcrumb__button" aria-expanded="false" aria-controls="breadcrumb-1">Voir le fil d’Ariane</button>
     <div class="fr-collapse" id="breadcrumb-1">
         <ol class="fr-breadcrumb__list">

diff --git a/dsfr/templates/dsfr/footer.html b/dsfr/templates/dsfr/footer.html
@@ -1,4 +1,4 @@
-<footer class="fr-footer" id="footer">
+<footer role="contentinfo" class="fr-footer" id="footer">
   <div class="fr-container">
     <div class="fr-footer__body">
       <div class="fr-footer__brand fr-enlarge-link">

diff --git a/dsfr/templates/dsfr/header.html b/dsfr/templates/dsfr/header.html
@@ -1,4 +1,4 @@
-<header class="fr-header">
+<header role="banner" class="fr-header">
   <div class="fr-header__body">
     <div class="fr-container">
       <div class="fr-header__body-row">
@@ -59,7 +59,7 @@
       <div class="fr-container">
         <button class="fr-btn--close fr-btn" aria-controls="fr-menu-mobile">Fermer</button>
         <div class="fr-header__menu-links"></div>
-        <nav class="fr-nav" id="fr-navigation" aria-label="Menu principal">
+        <nav role="navigation" class="fr-nav" id="fr-navigation" aria-label="Menu principal">
           <ul class="fr-nav__list">
             <li class="fr-nav__item">
               <a class="fr-nav__link" href="#" target="_self">accès direct</a>

diff --git a/dsfr/templates/dsfr/pagination.html b/dsfr/templates/dsfr/pagination.html
@@ -1,5 +1,5 @@
 {% load dsfr_tags %}
-<nav class="fr-pagination" aria-label="Pagination">
+<nav role="navigation" class="fr-pagination" aria-label="Pagination">
     <ul class="fr-pagination__list">
         <li>
             <a

diff --git a/dsfr/templates/dsfr/sidemenu.html b/dsfr/templates/dsfr/sidemenu.html
@@ -1,5 +1,5 @@
 {% load dsfr_tags %}
-<nav class="fr-sidemenu{% if self.extra_classes %} {{ self.extra_classes }}{% endif %}" aria-label="Menu latéral">
+<nav role="navigation" class="fr-sidemenu{% if self.extra_classes %} {{ self.extra_classes }}{% endif %}" aria-label="Menu latéral">
   <div class="fr-sidemenu__inner">
     <button type="button" class="fr-sidemenu__btn" aria-controls="fr-sidemenu-wrapper" aria-expanded="false">Dans cette rubrique</button>
     <div class="fr-collapse" id="fr-sidemenu-wrapper">

diff --git a/dsfr/templates/dsfr/skiplinks.html b/dsfr/templates/dsfr/skiplinks.html
@@ -1,5 +1,5 @@
 <div class="fr-skiplinks">
-    <nav class="fr-container" aria-label="Accès rapide">
+    <nav role="navigation" class="fr-container" aria-label="Accès rapide">
         <ul class="fr-skiplinks__list">
           {% for item in self.items %}
           <li>

diff --git a/dsfr/templates/dsfr/summary.html b/dsfr/templates/dsfr/summary.html
@@ -1,4 +1,4 @@
-<nav class="fr-summary" aria-labelledby="fr-summary-title">
+<nav role="navigation" class="fr-summary" aria-labelledby="fr-summary-title">
     <div class="fr-summary__title" id="fr-summary-title">Sommaire</div>
     <ol class="fr-summary__list">
         {% for item in self.items %}

diff --git a/dsfr/test/test_templatetags.py b/dsfr/test/test_templatetags.py
@@ -599,7 +599,7 @@ def test_summary_tag_rendered(self):
         rendered_template = self.template_to_render.render(self.context)
         self.assertInHTML(
             """
-            <nav class="fr-summary" aria-labelledby="fr-summary-title">
+            <nav role="navigation" class="fr-summary" aria-labelledby="fr-summary-title">
                 <div class="fr-summary__title" id="fr-summary-title">Sommaire</div>
                 <ol class="fr-summary__list">
                     
@@ -631,7 +631,7 @@ def test_summary_tag_rendered(self):
         self.assertInHTML(
             """
             <div class="fr-skiplinks">
-                <nav class="fr-container" aria-label="Accès rapide">
+                <nav role="navigation" class="fr-container" aria-label="Accès rapide">
                     <ul class="fr-skiplinks__list">
                     <li>
                         <a class="fr-link" href="#contenu">Contenu</a>

diff --git a/example_app/templates/example_app/base.html b/example_app/templates/example_app/base.html
@@ -31,7 +31,7 @@
     <div class="fr-container fr-mt-4w fr-mb-6w">
       {% dsfr_breadcrumb %}
 
-      <main id="content">
+      <main id="content" role="main">
         {% block content %}{% endblock content %}
       </main>
     </div>

diff --git a/example_app/templates/example_app/blocks/header.html b/example_app/templates/example_app/blocks/header.html
@@ -23,7 +23,7 @@
       <div class="fr-container">
         <button type="button" class="fr-btn--close fr-btn" aria-controls="fr-menu-mobile">Fermer</button>
         <div class="fr-header__menu-links"></div>
-        <nav class="fr-nav" id="fr-navigation" aria-label="Menu principal">
+        <nav role="navigation" class="fr-nav" id="fr-navigation" aria-label="Menu principal">
           <ul class="fr-nav__list">
             <li class="fr-nav__item">
               <a class="fr-nav__link" href="{% url 'index' %}" target="_self">Accueil</a>

diff --git a/pyproject.toml b/pyproject.toml
@@ -3,7 +3,7 @@ authors = ["Sylvain Boissel <[email protected]>"]
 description = "Integrate the French government Design System into a Django app"
 license = "MIT"
 name = "django-dsfr"
-version = "0.7.2"
+version = "0.7.3"
 
 classifiers = [
   "Development Status :: 3 - Alpha",