Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ControlledTerm errors in ChangesetErrors.error_details/1 #1580

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

bmquinn
Copy link
Contributor

@bmquinn bmquinn commented Dec 9, 2020

  • Adds format_error/1 private functions to MeadowWeb.Schema.ChangesetErrors in order to translate {:error, 404} and {:error, :unknown_authority} responses from Authoritex for human readability.
  • Adds tests for MeadowWeb.Schema.ChangesetErrors that didn't exist previously.
  • Upgrades Authoritex to 0.5.0 to use the new mock prefix missing_id_authority: which forces an {:error, 404} response (though this implementation will likely change soon: see Rewrite Mock to handle known authorities authoritex#43 for more information)

@bmquinn bmquinn requested review from mbklein and kdid December 9, 2020 21:53
@mbklein mbklein merged commit 6500234 into deploy/staging Dec 9, 2020
@mbklein mbklein deleted the 1246-controlled-term-bug branch December 9, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants