Blood: Add option to select MIDI MME device #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyqlfpir
force-pushed
the
master
branch
2 times, most recently
from
b2be48d to
d37fa75
Compare
Hendricks266
reviewed
Sep 7, 2024
tmyqlfpir
force-pushed
the
master
branch
3 times, most recently
from
16bb39c to
2a0c64c
Compare
|
I see unrelated commits in this PR. Normally a new feature should be in a feature branch inside a fork, but I see here master. |
I'm okay with slipstreaming small fixes into feature branches as long as they're cleanly separated into their own commits, which they are. I do agree that it might be better not to use the |
|
I had only planned on making one PR which is why I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to change the MME device index for system MIDI playback (only for Windows based systems).
Fixes #831