Apply suggestions from code review

Co-authored-by: Paul Wilson <[email protected]> Signed-off-by: Katie Mummah <[email protected]>
nuclearkatie · Sep 12, 2024 · 8abc7a7 · 8abc7a7
1 parent 45e8af9
commit 8abc7a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/res_tracker.cc b/src/res_tracker.cc
@@ -53,9 +53,9 @@ void ResTracker::Extract(ResTracker* removed) {
     Record();
   }
 
-    removed->parent1_ = res_->state_id();
-    removed->parent2_ = 0;
-    removed->tracked_ = tracked_;
+  removed->parent1_ = res_->state_id();
+  removed->parent2_ = 0;
+  removed->tracked_ = tracked_;
 
   removed->Record();
 }

diff --git a/src/res_tracker.h b/src/res_tracker.h
@@ -49,7 +49,7 @@ class ResTracker {
   void Package(ResTracker* parent = NULL);
 
  private:
-  void Record(bool no_bump = false);
+  void Record(bool bumpId = true);
 
   int parent1_;
   int parent2_;

diff --git a/src/resource.h b/src/resource.h
@@ -95,7 +95,7 @@ class Resource {
   /// Returns the package id.
   virtual std::string package_name() { return Package::unpackaged_name(); };
 
-  virtual Ptr PackageExtract(double qty, std::string new_package_name = Package::unpackaged_name()) = 0;
+  virtual Ptr PackageExtract(double qty, std::string new_package_name) = 0;
 
   /// Changes the product's package id
   virtual void ChangePackage(std::string new_package_name = Package::unpackaged_name()) {};