Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Paul Wilson <[email protected]>
Signed-off-by: Katie Mummah <[email protected]>
  • Loading branch information
nuclearkatie and gonuke authored Feb 26, 2024
1 parent ac897e5 commit 592ea7d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/material.h
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class Material: public Resource {
virtual void ChangePackageId(int new_package_id);

protected:
Material(Context* ctx, double quantity, Composition::Ptr c, int package_id = 1);
Material(Context* ctx, double quantity, Composition::Ptr c, int package_id = default_package_id_);

private:
Context* ctx_;
Expand Down
4 changes: 2 additions & 2 deletions src/product.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Product : public Resource {
/// pointer to the agent creating the resource (usually will be the caller's
/// "this" pointer). All future output data recorded will be done using the
/// creator's context.
static Ptr Create(Agent* creator, double quantity, std::string quality, int package_id = 1);
static Ptr Create(Agent* creator, double quantity, std::string quality, int package_id = default_package_id_);

/// Creates a new product that does not actually exist as part of
/// the simulation and is untracked.
Expand Down Expand Up @@ -75,7 +75,7 @@ class Product : public Resource {
/// @param ctx the simulation context
/// @param quantity is a double indicating the quantity
/// @param quality the resource quality
Product(Context* ctx, double quantity, std::string quality, int package_id = 1);
Product(Context* ctx, double quantity, std::string quality, int package_id = default_package_id_);

// map<quality, quality_id>
static std::map<std::string, int> qualids_;
Expand Down

0 comments on commit 592ea7d

Please sign in to comment.