Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Poison with Jason #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ybod
Copy link

@ybod ybod commented Apr 4, 2019

  1. Replace Poison with Jason for JSON encoding/decoding
  2. Update hex_doc version
  3. Format code with mix format

@ntrepid8
Copy link
Owner

ntrepid8 commented Apr 4, 2019

What is the motivation for using Jason rather than Poison?

@ybod
Copy link
Author

ybod commented Apr 5, 2019

Jason is faster and "smaller", many projects already switched to Jason.

.formatter.exs Outdated Show resolved Hide resolved
@cgorshing
Copy link

cgorshing commented Feb 4, 2020

I came here to request these changes as well. As Phoenix comes with Jason already as a dependency, many projects are following suite to keep from bringing in dependencies that do the same thing.

If you don't want to use a json library directly, then maybe we could tie it to a behaviour or something like https://github.com/scrogson/oauth2/#configure-a-serializer

Another example of people asking for this
parroty/extwitter#121

@ntrepid8
Copy link
Owner

ntrepid8 commented Feb 4, 2020

I'm not opposed to using Jason :)

Mostly I need to figure out why Travis isn't running the CI jobs anymore :(

@barttenbrinke
Copy link
Contributor

barttenbrinke commented Sep 8, 2021

Can somebody merge this? Oh, I see Poison has a new maintainer now 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants