Add Github Action for publish spec to NeoFS #87
Conversation
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
110183b to
612b1b4
Compare
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
ac89fe6 to
6966479
Compare
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
6966479 to
7e6c237
Compare
.github/workflows/neofs.yml
Outdated
| steps: | ||
| - name: Set PATH_TO_FILES_DIR | ||
| run: | | ||
| echo "PATH_TO_FILES_DIR=output/neofs-spec-$(make version).pdf" |
There was a problem hiding this comment.
echo "PATH_TO_FILES_DIR=output" >> $GITHUB_ENV
.github/workflows/neofs.yml
Outdated
| push: | ||
| branches: [ master ] | ||
|
|
||
| env: |
There was a problem hiding this comment.
Remove the variable definitions from here - they will be set by @roman-khimov in the repository settings.
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
4351eb8 to
c05f16a
Compare
| with: | ||
| NEOFS_WALLET: ${{ secrets.NEOFS_WALLET }} | ||
| NEOFS_WALLET_PASSWORD: ${{ secrets.NEOFS_WALLET_PASSWORD }} | ||
| NEOFS_NETWORK_DOMAIN: ${{ env.NEOFS_NETWORK_DOMAIN }} |
There was a problem hiding this comment.
@vvarg229, why do we have a domain here?
There was a problem hiding this comment.
@vvarg229, why do we have a domain here?
How else do you identify which neofs network to use?
There was a problem hiding this comment.
To produce a link to download/view the uploaded thing.
.github/workflows/neofs.yml
Outdated
| steps: | ||
| - name: Set PATH_TO_FILES_DIR | ||
| run: | | ||
| echo "PATH_TO_FILES_DIR=output" >> $GITHUB_ENV |
There was a problem hiding this comment.
why is it hardcoded and not an env? @vvarg229
There was a problem hiding this comment.
why is it hardcoded and not an env? @vvarg229
Yes, you can put this variable into GitHub variables from the web interface
There was a problem hiding this comment.
Looks like there is some inconsistency there, we have PATH_TO_FILES_DIR in an env, but here it's hardcoded to a particular value appropriate for make docker/pdf.
.github/workflows/neofs.yml
Outdated
| steps: | ||
| - name: Set PATH_TO_FILES_DIR | ||
| run: | | ||
| echo "PATH_TO_FILES_DIR=output" >> $GITHUB_ENV |
There was a problem hiding this comment.
Looks like there is some inconsistency there, we have PATH_TO_FILES_DIR in an env, but here it's hardcoded to a particular value appropriate for make docker/pdf.
|
I've added envs/secrets (except PATH_TO_FILES_DIR). But we need to synchronize the name of the uploaded spec with the website then (see nspcc-dev/gh-push-to-neofs#2 also). |
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
c05f16a to
3d2b003
Compare
closes #85 Signed-off-by: Mikhail Petrov <[email protected]>
mike-petrov
force-pushed
the
feature/85-build_and_publish_to_neofs
branch
from
72a39a6 to
113b8ab
Compare
Signed-off-by: Mikhail Petrov [email protected]
closes #85