Feat/Optional homomorphic hashing #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
optional-homomorphic-hashing
branch
from
d4c42da to
0710e26
Compare
fyrchik
previously approved these changes
Jul 1, 2022
carpawell
force-pushed
the
optional-homomorphic-hashing
branch
2 times, most recently
from
49c9392 to
718b47e
Compare
|
Rebased after #272. |
| // Returns any network/parsing config errors. | ||
| // | ||
| // See also NetworkInfo, container.ApplyNetworkConfig. | ||
| func SyncContainerWithNetwork(ctx context.Context, cnr *container.Container, c *Client) error { |
There was a problem hiding this comment.
Lets add similar function to pool package, it'd be useful in services like S3 gateway https://github.com/nspcc-dev/neofs-s3-gw/blob/5bfc54974669bfddf1e9693d9625578a8167778f/internal/neofs/neofs.go#L137.
There was a problem hiding this comment.
/cc @alexvanin, @KirillovDenis
carpawell
force-pushed
the
optional-homomorphic-hashing
branch
2 times, most recently
from
05c6acc to
7a41e73
Compare
carpawell
force-pushed
the
optional-homomorphic-hashing
branch
2 times, most recently
from
3474898 to
36864a8
Compare
cthulhu-rider
requested changes
Jul 5, 2022
Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
It requests network configuration and syncs it (changes if required) with passed container. Signed-off-by: Pavel Karpy <[email protected]>
It is a helper function that uses a `Pool` to fetch network information and apply it to the container (change the container if it does not fit the network). Currently, only applies the homomorphic hashing parameter. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
optional-homomorphic-hashing
branch
from
36864a8 to
572ada0
Compare
cthulhu-rider
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.