cleanup(core): migrate to picospinner #29138
Conversation
Migrates from `ora` to `picospinner`, a much lighter package.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 53fa439. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
|
@43081j I was thinking we would go for Please could you confirm this library does not have this issue? (Should be able to modify the linked stackblitz) and how the two libraries compare? |
|
I'll take a look when I can 👍 The two libraries are pretty well aligned, so it comes mostly down to personal preference. picospinner is a bit more customisable Both maintainers are active in our community too, so you really could just flip a coin here 😅 |
There was a problem hiding this comment.
@43081j I added picospinner to my comparison with ora and nanospinner:
https://stackblitz.com/edit/stackblitz-starters-dmnx9n?file=package.json&view=editor
It seems like it doesn't actually allow for the error handling at all. Maybe it is calling process.exit itself?
- ora: works as expected but bloated
- nanospinner: has double printing issue on exit
- picospinner: does not allow for exceptions to be handled
We cannot proceed until one of nanospinner or picospinner matches the functionality/robustness of ora I'm afraid
|
All good, I'll look into this today or tomorrow 👍 I'm mobile at the minute so can't dig into it but I'll figure it out once I'm at a laptop |
Migrates from
oratopicospinner, a much lighter package.this should roughly be a drop in replacement and will be faster/lighter. it is maintained by the tinylibs org