[nrf noup] use -DUSE_PARTITION_MANAGER=1 for lld linker script template #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
approved these changes
Dec 10, 2024
nordicjm
reviewed
Dec 10, 2024
| @@ -52,6 +52,7 @@ macro(configure_linker_script linker_script_gen linker_pass_define) | |||
| -imacros ${AUTOCONF_H} | |||
| ${current_includes} | |||
| ${template_script_defines} | |||
| -DUSE_PARTITION_MANAGER=$<OR:$<BOOL:${CONFIG_PARTITION_MANAGER_ENABLED}>,$<BOOL:${IMAGE_NAME}>,$<TARGET_EXISTS:partition_manager>> | |||
There was a problem hiding this comment.
can optionally be condensed to -DUSE_PARTITION_MANAGER=$<BOOL:${CONFIG_PARTITION_MANAGER_ENABLED}> since this doesn't need to support child/parent and it's currently being removed
There was a problem hiding this comment.
as you said yourself, parent/child is currently being removed so it's anyhow a short-lived solution, and for that I simply prefer to keep this line aligned with the construct used already in the ld/target.cmake.
… template fixup! [nrf noup] tree-wide: support NCS Partition Manager (PM) definitions Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
issues/569_lld_partition_manager
branch
from
0704fa5 to
df3e860
Compare
carlescufi
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup! [nrf noup] tree-wide: support NCS Partition Manager (PM) definitions