Bluetooth: Controller: Implement LE Set Extended Advertising Paramete… #19662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Thomas-Deppe
force-pushed
the
implement_set_extended_advertising_parameters_v2
branch
from
1302b94 to
d7426e7
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 42d10f3086a059a317f529f0c8c19bdb562270b4 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
| @@ -762,6 +764,7 @@ void hci_internal_le_supported_features( | |||
|
|
|||
| #ifdef CONFIG_BT_CTLR_ADV_EXT | |||
| features->params.le_extended_advertising = 1; | |||
| features->params.advertising_coding_selection = 1; | |||
There was a problem hiding this comment.
Is the feature bit set no matter if coded phy is enabled?
There was a problem hiding this comment.
I can change this, my mistake. Do I need to do the same in the #ifdef above this?
There was a problem hiding this comment.
We support the API independent of the support of coded phy. If coded PHY is not supported will will just not transmit on the particular coding scheme, and also not raise reports with Coded PHY
There was a problem hiding this comment.
Ok, then we can keep it as is
Thomas-Deppe
force-pushed
the
implement_set_extended_advertising_parameters_v2
branch
2 times, most recently
from
ec177f0 to
b8de38b
Compare
rugeGerritsen
approved these changes
Dec 19, 2024
jostn
approved these changes
Dec 20, 2024
Thomas-Deppe
force-pushed
the
implement_set_extended_advertising_parameters_v2
branch
from
b8de38b to
8d6b698
Compare
Implement LE Set Extended Advertising Parameters [v2] command as per bluetooth spec v6.0 (Vol 4 Part E Section 7.8.53). Advertising Coding Selection is marked as supported. Signed-off-by: Thomas Deppe <[email protected]>
Thomas-Deppe
force-pushed
the
implement_set_extended_advertising_parameters_v2
branch
from
8d6b698 to
42d10f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rs v2 command
Implement LE Set Extended Advertising Parameters [v2] command as per Bluetooth spec v6.0 (Vol 4 Part E Section 7.8.53). Advertising Coding Selection is marked as supported.