Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix throughput degradation #18930

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

D-Triveni
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 18, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 18, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 074ce4acc1a2e58c31331d0467ac72ee9d64a22f

more details

sdk-nrf:

PR head: 074ce4acc1a2e58c31331d0467ac72ee9d64a22f
merge base: 66b211a8e682d80c49bdb092247a5e50acc8db89
target head (main): 66b211a8e682d80c49bdb092247a5e50acc8db89
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
samples
│  ├── wifi
│  │  ├── throughput
│  │  │  ├── README.rst
│  │  │  ├── overlay-high-performance.conf
│  │  │  ├── overlay-iot-devices.conf
│  │  │  ├── overlay-memory-optimized.conf
│  │  │  ├── overlay-rx-prio.conf
│  │  │  │ overlay-tx-prio.conf

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 161
  • ✅ Integration tests
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@D-Triveni D-Triveni force-pushed the fix_tput_degradation branch 2 times, most recently from a3b56b9 to 4238aaa Compare November 21, 2024 10:07
@D-Triveni D-Triveni added the wifi-qa-required Needs an Approval from Wi-Fi QA team before merging. label Nov 22, 2024
@D-Triveni D-Triveni force-pushed the fix_tput_degradation branch from 4238aaa to 3cc15c3 Compare November 22, 2024 10:08
@D-Triveni D-Triveni requested a review from a team as a code owner November 22, 2024 10:08
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 22, 2024
@D-Triveni D-Triveni requested a review from richabp November 22, 2024 10:09
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@bama-nordic
Copy link
Contributor

Firstly, we need to add more targets to this sample - EK, 54H/L and ensure at least the IoT and mem optimized profiles can work. Secondly, we need to adjust the HEAP memory to scale according to the profile... we cannot have 260K allocated to HEAP for all profiles. The idea of using these profiles is to to tell the customer a mapping of throughputs v/s RAM and code footprints. We need to discuss internally and align the intention of this sample appropriately.

Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 26, 2024
This option should be enabled to enable the PicoLibc speed optimization
for optimized throughput performance.

Signed-off-by: Triveni Danda <[email protected]>
This change is done to ensure improved throughput
by increasing RX buffers in the nRF700x driver.

Signed-off-by: Triveni Danda <[email protected]>
Modify the pool sizes to different values for more accurate
throughput optimization, as with the fixed configuration.

Signed-off-by: Triveni Danda <[email protected]>
@D-Triveni D-Triveni force-pushed the fix_tput_degradation branch from 3cc15c3 to 074ce4a Compare December 26, 2024 07:43
@github-actions github-actions bot removed the Stale label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval. wifi-qa-required Needs an Approval from Wi-Fi QA team before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants