Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize output and flags #193

Merged
merged 44 commits into from
Oct 2, 2024
Merged

Optimize output and flags #193

merged 44 commits into from
Oct 2, 2024

Conversation

YairSlobodin1
Copy link
Member

@YairSlobodin1 YairSlobodin1 commented Aug 26, 2024 •
edited
Loading

2nd and 3rd bullets of #191

@YairSlobodin1 YairSlobodin1 marked this pull request as draft August 26, 2024 11:33
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 26, 2024
@YairSlobodin1 YairSlobodin1 marked this pull request as ready for review August 28, 2024 13:34
Base automatically changed from read_sgs to optimize October 1, 2024 06:52
zivnevo
zivnevo requested changes Oct 1, 2024
View reviewed changes
cmd/subcmds/root.go Outdated Show resolved Hide resolved
pkg/optimize/common.go Outdated Show resolved Hide resolved
pkg/optimize/sg.go Outdated Show resolved Hide resolved
pkg/ir/acl.go Outdated Show resolved Hide resolved
pkg/io/csvio/sg.go Show resolved Hide resolved
cmd/subcmds/optimizeSG.go Outdated Show resolved Hide resolved
cmd/subcmds/verifyFlags.go Outdated Show resolved Hide resolved
cmd/subcmds/root.go Show resolved Hide resolved
cmd/subcmds/verifyFlags.go Outdated Show resolved Hide resolved
@YairSlobodin1
Copy link
Member Author

YairSlobodin1 commented Oct 1, 2024 •
edited
Loading

should also change rootCmd description. Any ideas?

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Oct 1, 2024
@YairSlobodin1 YairSlobodin1 requested a review from zivnevo October 1, 2024 18:23
@YairSlobodin1 YairSlobodin1 mentioned this pull request Oct 1, 2024
Draft
6 tasks
zivnevo
zivnevo reviewed Oct 2, 2024
View reviewed changes
cmd/subcmds/output.go Show resolved Hide resolved
pkg/io/csvio/sg.go Show resolved Hide resolved
zivnevo
zivnevo reviewed Oct 2, 2024
View reviewed changes
cmd/subcmds/output.go Outdated Show resolved Hide resolved
@zivnevo
Copy link
Member

zivnevo commented Oct 2, 2024

should also change rootCmd description. Any ideas?

"A tool for synthesizing and optimizing VPC network configurations"

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Oct 2, 2024
@YairSlobodin1 YairSlobodin1 requested a review from zivnevo October 2, 2024 08:17
@YairSlobodin1 YairSlobodin1 merged commit 02cae44 into optimize Oct 2, 2024
3 checks passed
@YairSlobodin1 YairSlobodin1 deleted the output branch October 2, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YairSlobodin1 @zivnevo