Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Prometheus-scrapable ports to all pods in the cluster #434

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Expose Prometheus-scrapable ports to all pods in the cluster #434

merged 3 commits into from
Aug 8, 2024

Conversation

zivnevo
Copy link
Member

@zivnevo zivnevo commented Jul 11, 2024 •
edited
Loading

Fixes #371

@zivnevo zivnevo requested a review from adisos July 16, 2024 06:30
adisos
adisos reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added just small questions

tests/sockshop/manifests/26-user-svc.yaml Show resolved Hide resolved
tests/sockshop/expected_netpol_output.json Show resolved Hide resolved
@zivnevo zivnevo merged commit 3cef037 into main Aug 8, 2024
6 checks passed
@zivnevo zivnevo deleted the detect-prometheus-scrape-ports branch August 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect required connectivity to Prometheus
2 participants
@zivnevo @adisos