Improved search for network addresses within a given string #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZIV NEVO <[email protected]>
Signed-off-by: ZIV NEVO <[email protected]>
Signed-off-by: ZIV NEVO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Also checks various suffixes of the given string to see if they can be interpreted as a network address. Starts from the whole string, then checks shorter and shorter suffixes.
This comes to identify network addresses in command-line args like
-server-addr=my_server:5000orserver-addr:my_server:5000.Since we now find more suspects, a validation of the port number/name was also added, to rule-out strings that are clearly not network addresses.