Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise Graphics file structure. #587

Merged
merged 4 commits into from
Jul 2, 2023

Conversation

RubyNova
Copy link
Member

@RubyNova RubyNova commented Jul 1, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a sub-contribution for #583 and not a functional change.

Is there an open issue that this resolves? If so, please link it here.
No.

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior (if this is a feature change)?
N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:

@RubyNova RubyNova added feature A feature ticket for the NovelRT. engine core Tickets pertaining to the engine core codebase. engine api Tickets pertaining to NovelRT's end-user API. labels Jul 1, 2023
Copy link
Contributor

@FiniteReality FiniteReality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting other people to do your work for you 101

@RubyNova RubyNova requested a review from capnkenny as a code owner July 2, 2023 00:09
@FiniteReality FiniteReality merged commit b78f194 into main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine api Tickets pertaining to NovelRT's end-user API. engine core Tickets pertaining to the engine core codebase. feature A feature ticket for the NovelRT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants