Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of the handler function to router #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notwaving
Copy link
Owner

Hope this is the right file!

#codebar24PR2017

Hope this is the right file!

#codebar24PR2017
@claireinez
Copy link

claireinez commented Dec 13, 2017

Hi @notwaving, thanks for making a PR 🎉 I think you might want to raise it over on the Node Girls repo though?

I see that your work is in response to this issue but we need to change any reference to handlers throughout the workshop to be consistent, and I see it mentioned in a few other files. Also, in step 7, we ask people to make a file called handler.js but that needs to be changed to router.js.

If you have any problems, please do give us a nudge! I'm sure @ZooeyMiller will also be happy to help :) Thanks again for taking the time to help us out! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants