🐛 I91 fix importer issues #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
status_info was deprecated in Bulkrax v6.0.0. It has been updated to set_status_info. We were also receiving an error because of nil values, so record.compact! is needed.
In this commit we remove bulkrax_metadata.yml since there's nothing custom about it; it will inherit settings from Hyku instead. Additionally we add a search_field key to the bulkrax.rb, for the bulkrax_identifier mapping.
ShanaLMoore
commented
Jun 18, 2024
| @@ -16,7 +17,7 @@ def valid_import? | |||
|
|
|||
| file_paths.is_a?(Array) | |||
| rescue StandardError => e | |||
| status_info(e) | |||
There was a problem hiding this comment.
this method was deprecated in Bulkrax v6.0.0. Because of this, the imports would fail silently if there's an issue.
ShanaLMoore
commented
Jun 19, 2024
| @@ -78,10 +78,10 @@ def base64?(value) | |||
| def account_json_string | |||
| return @account_json_string if @account_json_string | |||
| @account_json_string = if @config['account_json'] | |||
| base64?(@config['account_json']) ? Base64.decode64(@config['account_json']) : @config['account_json'] | |||
ShanaLMoore
commented
Jun 19, 2024
There was a problem hiding this comment.
updates bulkrax
|
Are the spec failures valid? Or are they known flaky specs on this repo? |
they're known flakes. feature spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Update bulkrax for submodule, then update submodule for pals ✅
This corrects the reason why we were unable to import.
split-embargo-pals.zip
basic-pals-import.csv