🎁 adds reference and registers bulkrax transaction #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…behavior Update IiifPrint to sniff out if Bulkrax has a transaction for update_with_bulk_behavior and create_with_bulk_behavior (check if the constants are defined); then inject accordingly. Issue: - samvera/bulkrax#897
ShanaLMoore
force-pushed
the
i897-register-bulkrax-transactions
branch
from
be98410 to
4d1e317
Compare
kirkkwang
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Looks good, but looks like there are some linting to be done
Offenses:
app/transactions/hyrax/transactions/iiif_print_container_decorator.rb:41:72: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
ops.register Bulkrax::Container::UPDATE_WITH_BULK_BEHAVIOR do
^
app/transactions/hyrax/transactions/iiif_print_container_decorator.rb:44:62: C: [Correctable] Layout/TrailingWhitespace: Trailing whitespace detected.
Hyrax::Transactions::WorkUpdate.new(steps: steps)
^^^^
Oops, I missed scrolling down to see that. I'll fix it. thanks for pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update IiifPrint to sniff out if Bulkrax has a transaction for update_with_bulk_behavior and create_with_bulk_behavior (check if the constants are defined); then inject accordingly.
Related Issue: