🐛 Sort by: Published Date #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit pulls in an update to Hyku that fixes a bug when sorting by title, author, and created date (published date). The Hyku indexing moves from `CollectionResource` to `CollectionResourceIndexer`. Ref: - #185
This commit updates the submodule to the latest version of Hyku which removes HykuIndexing mix in from the CollectionResource model and adds HykuIndexing mix in to CollectionResourceIndexer to fix a bug when sorting the catalog. Hyku PR: samvera/hyku#2327 Ref: - #185
…ck into fix-sort-by-attributes
Pulls in the latest changes from the hyrax-webapp submodule to address a failing spec. Ref: - #185
kirkkwang
approved these changes
Sep 20, 2024
This commit improves communication of intent by removing the multiple indicator from the sorting configs since the sort happens on a single item from each field. Ref: - #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
The "Sort by Published Date" (both ascending and descending) feature in the catalog search and in collections does not properly sort based on the "Publication date" metadata field.
Ref:
Expected Behavior Before Changes
Title, author, and publication date sort fields did not sort properly on the catalog search results page or the collection show page.
Expected Behavior After Changes
The user is able to sort by title, author, and publication date on the catalog search results page as well as the collection show page.
Screenshots / Video
Screen.Recording.2024-09-17.at.3.14.37.PM.mov
Notes
This updated required an update of the submodule as well as reindexing local works and collections.