🎁 Prohibits blank metadata fields from rendering #806
Conversation
This commit is a temporary solution to prevent blank metadata fields from rendering. There is a bigger issue of why some fields are being assigned values of `[""]` but this commit solves the current issue. Ref: - #771
|
oops. I accidentally triggered a re review from Kirk after he already approved it. Please disregard. cc @sjproctor could you manually build-test-lint this branch before merging since it doesn't auto run? To further clarify, this project won't auto run the pipeline since we aren't merging into main yet. You have to trigger it manually under the actions tab. I like to screenshot the ci results and attach it to the PRs in this case, since the green checkmark here is deceiving. ie: 
vs 
let me know if you need help with that |
|
@sjproctor Thanks for trying. I forgot we were having issues on the pipeline yesterday, which is likely where you branched off of. I think this branch would need a build-test-lint update and a submodule update to get the pipeline to run. could you try updating this branch with pull-in-hyku-knapsack and try running it again? |
…/adventist_knapsack into blank-metadata-properties
Story
This commit is a temporary solution to prevent blank metadata fields from rendering. There is a bigger issue of why some fields are being assigned values of
[""]but this commit solves the current issue.Ref:
Expected Behavior Before Changes
Some metadata fields that did not have content were rending on the works.
Expected Behavior After Changes
Only metadata fields that have content will render.
Screenshots / Video
Before:
After:
Notes
This is a temporary solution to solve the current needs of the client.