This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
🎁 Filter certain file sets from manifests #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
force-pushed
the
i679-remove-thumbnails-and-non-image-file-sets
branch
from
b1bb7aa to
9e77506
Compare
ShanaLMoore
approved these changes
Nov 28, 2023
kirkkwang
force-pushed
the
i679-remove-thumbnails-and-non-image-file-sets
branch
from
9e77506 to
4e75400
Compare
This commit will remove thumbnail file sets and non-image file sets at a much higher level than before. Previously, we were filtering out the thumbnails at the manifest builder level which is right before the manifest gets generated. This caused issues with serverless IIIF resources when the file sets (such as thumbnails or text files) were not properly ingested. This shouldn't break the manifest generation since these kinds of file sets are not able to be displayed in the Universal Viewer. Filtering these out at a higher level means it doesn't even make it to the serverless IIIF portion of the code in IIIF Print. Ref: - https://github.com/scientist-softserv/adventist-dl/issues/679
kirkkwang
force-pushed
the
i679-remove-thumbnails-and-non-image-file-sets
branch
from
4e75400 to
3526791
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will remove thumbnail file sets and non-image file sets at a much higher level than before. Previously, we were filtering out the thumbnails at the manifest builder level which is right before the manifest gets generated. This caused issues with serverless IIIF resources when the file sets (such as thumbnails or text files) were not properly ingested. This shouldn't break the manifest generation since these kinds of file sets are not able to be displayed in the Universal Viewer. Filtering these out at a higher level means it doesn't even make it to the serverless IIIF portion of the code in IIIF Print.
Ref:
TODO:
This should be implemented in Knapsack as well. Adding the
Knapsack Upgradelabel as a reminder.