This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
♻️ Re-arrange method structure in hopes of not swallowing exception #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
amending-decorator-to-have-information
branch
from
60161aa to
ad8f95e
Compare
We are observing that this job is raising an exception, which is then swallowed (and "pooped out" to the mailboxer notifications for the submitting user; which is not helpful when tracking down the particulars). Confounding part is that the reported errors, don't seem to be affecting the attachment of files. In other words, we get a notification of failure but it worked (the majority of the time). Co-authored-by: LaRita Robinson <[email protected]>
jeremyf
force-pushed
the
amending-decorator-to-have-information
branch
from
ad8f95e to
f981c8f
Compare
laritakr
reviewed
Nov 22, 2023
|
This did not work. I submitted a bunch of OAI ingests. The changes totally broke it. ImportUrlJob resubmitted itself 5 times and ended without doing anything, sending any notifications, or reporting any errors. |
laritakr
suggested changes
Nov 24, 2023
There was a problem hiding this comment.
Does not work. ImportUrlJob resubmits 5 times and ends with no errors or notifications.
This was one of the test works: https://adl.s2.adventistdigitallibrary.org/concern/published_works/20088854_atlantic_union_gleaner_january_6_1904?locale=en
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are observing that this job is raising an exception, which is then swallowed (and "pooped out" to the mailboxer notifications for the submitting user; which is not helpful when tracking down the particulars).
Confounding part is that the reported errors, don't seem to be affecting the attachment of files. In other words, we get a notification of failure but it worked (the majority of the time).