This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
🎁 add helpful query attributes to iiif_print_pending_relationships #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
commented
Nov 10, 2023
| @@ -17,7 +17,7 @@ module AdventistPagesToJpgsSplitter | |||
| # | |||
| # @see https://github.com/scientist-softserv/iiif_print/blob/a23706453f23e0f54c9d50bbf0ddf9311d82a0b9/lib/iiif_print/jobs/child_works_from_pdf_job.rb#L39-L63 | |||
| def self.call(path, | |||
| splitter: DerivativeRodeoSplitter, | |||
| splitter: Rails.env.development? ? PagesToJpgsSplitter : DerivativeRodeoSplitter, | |||
There was a problem hiding this comment.
Note from Jeremy:
ShanaLMoore
commented
Nov 10, 2023
| @@ -142,6 +142,6 @@ gem 'blacklight_range_limit', '6.5.0' | |||
| gem 'dog_biscuits', git: 'https://github.com/samvera-labs/dog_biscuits.git' | |||
| gem 'hyrax-v2_graph_indexer', git: 'https://github.com/scientist-softserv/hyrax-v2_graph_indexer', branch: 'main' | |||
| # rubocop:disable Metrics/LineLength | |||
| gem 'iiif_print', git: 'https://github.com/scientist-softserv/iiif_print.git', ref: '56069b5f8bbcbf6629b9973352069d21d5ddaf0f' | |||
| gem 'iiif_print', git: 'https://github.com/scientist-softserv/iiif_print.git', branch: 'add-models-to-pending-relationships-table' | |||
There was a problem hiding this comment.
TODO: remove the branch reference and bundle update iiif_print --conservative once the corresponding PR gets approved/merged into iiif_print.
ShanaLMoore
changed the title
orangewolf
approved these changes
Nov 15, 2023
|
Update was included elsewhere |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are setting up the pending relationships table to make it easier to find relations.
related to
It will add parent_model, child_model, and file_id to the iiif_print_pending_relationships table.
TODO: update iiif print once the related PR gets merged into iiif print