feat: ber to der convertor #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Jan 18, 2024
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
reviewed
Jan 18, 2024
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176
JeyJeyGao
added a commit
to JeyJeyGao/tspclient-go
that referenced
this pull request
Jan 31, 2024
commit 2862807 Author: Junjie Gao <[email protected]> Date: Wed Jan 31 15:21:55 2024 +0800 feat: ber to der convertor (notaryproject#11) Signed-off-by: Junjie Gao <[email protected]> commit a373599 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:37:33 2024 +0800 ci: add MAKEFILE and build workflow to the repo (notaryproject#19) Signed-off-by: Patrick Zheng <[email protected]> commit 6fa8c7f Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:36:50 2024 +0800 ci: add dependabot (notaryproject#16) Signed-off-by: Patrick Zheng <[email protected]> commit bdae447 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:36:24 2024 +0800 ci: add code coverage check (notaryproject#15) Signed-off-by: Patrick Zheng <[email protected]> commit 4cc6846 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:35:54 2024 +0800 ci: add license checker to the repo (notaryproject#13) Signed-off-by: Patrick Zheng <[email protected]> commit a27c098 Author: Yi Zha <[email protected]> Date: Thu Jan 18 10:02:22 2024 +0800 chore: add CODEOWNERS and MAINTAINERS file (notaryproject#12) Resolve notaryproject#2 Signed-off-by: Yi Zha <[email protected]> Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junjie Gao [email protected]