Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update readme.md for the Notary Project #263

Merged
merged 10 commits into from
Aug 3, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Jun 10, 2023

Updates:

Note: The folder structure in this PR reflected the current structure. Any changes on folder structure proposed in notaryproject/.github#48, are not in the scope of this PR

Other PRs related to removing Notary v2 reference for this repository:

Signed-off-by: Yi Zha [email protected]

Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 marked this pull request as ready for review June 10, 2023 12:26
This was referenced Jun 10, 2023
@yizha1 yizha1 linked an issue Jun 11, 2023 that may be closed by this pull request
Signed-off-by: Yi Zha <[email protected]>
@yizha1
Copy link
Contributor Author

yizha1 commented Jun 12, 2023

NOTE: This PR will be amended later based on the Notary Project readme addressed by PR notaryproject/.github#32

@yizha1 yizha1 linked an issue Jun 12, 2023 that may be closed by this pull request
Copy link

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further clarity is still needed but this is an improvement thank you!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yizha1
Copy link
Contributor Author

yizha1 commented Jul 26, 2023

@yizha1 yizha1 requested a review from TheFoxAtWork July 26, 2023 09:40
FeynmanZhou
FeynmanZhou previously approved these changes Jul 31, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Yi Zha <[email protected]>
README.md Show resolved Hide resolved
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Aug 1, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with #271 opened

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamsamirzon
Copy link

LGTM but IAMNAM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@toddysm toddysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit d7e4195 into notaryproject:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul README.MD file Notation naming
9 participants