fix: dir no longer panics when HOME and XDG_CONFIG_HOME are not set (#449) #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
JeyJeyGao
changed the title
release-1.1 branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #450 +/- ##
===============================================
+ Coverage 80.19% 80.33% +0.13%
===============================================
Files 31 31
Lines 2101 2105 +4
===============================================
+ Hits 1685 1691 +6
+ Misses 288 287 -1
+ Partials 128 127 -1 ☔ View full report in Codecov by Sentry. |
Two-Hearts
reviewed
Sep 4, 2024
JeyJeyGao
changed the title
release-1.1 branch
Updated |
Two-Hearts
reviewed
Sep 4, 2024
…otaryproject#449) This PR addresses the issue notaryproject#446 In this PR I: - I removed the `init()` function from `dir/path` - When `userConfigDir()` returns an error, instead of `panic(err)` I default to the current directory instead - Split `loadUserPath()` into two new functions used to setup and return the values for `UserConfigDir` and `UserLibexecDir` - Added additional unit tests for the two new functions and to test the default directory is used when `HOME` is set to `""` --------- Signed-off-by: Jason <[email protected]> Signed-off-by: JasonTheDeveloper <[email protected]> Signed-off-by: Patrick Zheng <[email protected]> Co-authored-by: Shiwei Zhang <[email protected]> Co-authored-by: Patrick Zheng <[email protected]>
JeyJeyGao
force-pushed
the
fix/dir_1.1
branch
from
eb08659
to
73b4bf6
Compare
Thanks. Updated. |
JeyJeyGao
added a commit
that referenced
this pull request
Sep 9, 2024
## Release This would mean tagging 595c710 `v1.1.2` to release. ## Vote We need at least `4` approvals from `6` maintainers to release `notation-go v1.1.2`. - [x] Pritesh Bandi (@priteshbandi) - [x] Junjie Gao (@JeyJeyGao) - [ ] Rakesh Gariganti (@rgnote) - [ ] Milind Gokarn (@gokarnm) - [x] Shiwei Zhang (@shizhMSFT) - [x] Patrick Zheng (@Two-Hearts) ## What's Changed * fix&bump: maintenance update for branch `release-1.1` by @JeyJeyGao in #448 * fix: dir no longer panics when HOME and XDG_CONFIG_HOME are not set (#449) by @JeyJeyGao in #450 **Full Changelog**: v1.1.1...595c710 ## Actions Please review the PR and vote by approving. Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #446 for
release-1.1branchThis commit was cherry picked from commit 4d76f9a
In this PR I:
init()function fromdir/pathuserConfigDir()returns an error, instead ofpanic(err)Idefault to the current directory instead
loadUserPath()into two new functions used to setup and returnthe values for
UserConfigDirandUserLibexecDirdefault directory is used when
HOMEis set to""