Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support distinguished name state(S) #432

Merged
merged 9 commits into from
Aug 7, 2024

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 2, 2024

Resolves #431
Signed-off-by: Junjie Gao [email protected]

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (09e32d7) to head (ef85fc1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   80.73%   80.74%   +0.01%     
==========================================
  Files          33       33              
  Lines        2455     2457       +2     
==========================================
+ Hits         1982     1984       +2     
  Misses        331      331              
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only covers the parsing parts. It does not include the comparation between parsed values. For example, does ST=Shanghai equal S=Shanghai?

@JeyJeyGao
Copy link
Contributor Author

JeyJeyGao commented Aug 2, 2024

This PR only covers the parsing parts. It does not include the comparation between parsed values. For example, does ST=Shanghai equal S=Shanghai?

Yes, you are right. Updated.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Please sign your commits

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
Copy link
Contributor Author

LGTM;

Please sign your commits

Re-signed. Thanks!

@JeyJeyGao JeyJeyGao merged commit c3b2f51 into notaryproject:main Aug 7, 2024
7 checks passed
@JeyJeyGao JeyJeyGao deleted the feat/support_RDN_S branch August 7, 2024 02:07
@Two-Hearts Two-Hearts mentioned this pull request Aug 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional short name S for state/province
4 participants