feat: delta CRL #247
Open
feat: delta CRL #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 91.79% 92.03% +0.24%
==========================================
Files 30 30
Lines 2607 2762 +155
==========================================
+ Hits 2393 2542 +149
- Misses 163 167 +4
- Partials 51 53 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
JeyJeyGao
commented
Nov 28, 2024
| // FetcherWithCertificateExtensions is an interface that specifies methods used | ||
| // for fetching CRL from the given URL with certificate extensions to identify | ||
| // the Freshest CRL extension (Delta CRL) from certificate. | ||
| type FetcherWithCertificateExtensions interface { |
There was a problem hiding this comment.
There 2 sources of Delta CRL URL:
- certificate extension
- CRL extension
This interface enable user to pass a certificate extension to the fetcher for accessing the delta CRL.
JeyJeyGao
commented
Nov 29, 2024
| var dpDER cryptobyte.String | ||
| if !val.ReadASN1(&dpDER, cryptobyte_asn1.SEQUENCE) { | ||
| return nil, errors.New("x509: invalid CRL distribution point") | ||
| } |
There was a problem hiding this comment.
Those lines can hardly be triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat:
Limitation: only support 1 delta CRL URL