Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update key usage error message to make it clear #169

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

JeyJeyGao
Copy link
Contributor

Resolves #164
Signed-off-by: Junjie Gao [email protected]

Signed-off-by: Junjie Gao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #169 (b5856fb) into main (3f28a1b) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   89.13%   89.28%   +0.15%     
==========================================
  Files          21       21              
  Lines        1693     1718      +25     
==========================================
+ Hits         1509     1534      +25     
  Misses        149      149              
  Partials       35       35              
Files Coverage Δ
x509/cert_validations.go 84.86% <100.00%> (+1.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Junjie Gao <[email protected]>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JeyJeyGao

improve the error message a bit.

x509/cert_validations.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Oct 20, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x509/cert_validations.go Outdated Show resolved Hide resolved
x509/cert_validations.go Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Oct 23, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Oct 23, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x509/cert_validations.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and Two-Hearts via fd0d70f October 23, 2023 07:31
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit c834adc into notaryproject:main Oct 26, 2023
7 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Oct 26, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key usage error message
6 participants