Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added link to signature spec from troubleshooting entry #297

Merged
merged 1 commit into from
Dec 14, 2023
Merged

added link to signature spec from troubleshooting entry #297

merged 1 commit into from
Dec 14, 2023

Conversation

zr-msft
Copy link
Collaborator

@zr-msft zr-msft commented Jun 29, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit d408ffa
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/6509c64e7d34d00008e163f5
😎 Deploy Preview https://deploy-preview-297--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yizha1
yizha1 reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zr-msft

content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
FeynmanZhou
FeynmanZhou previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zr-msft
Copy link
Collaborator Author

zr-msft commented Sep 12, 2023

@FeynmanZhou and @yizha1 rebased to resolve conflict. Can you approve again so I can merge?

yizha1
yizha1 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zr-msft
Copy link
Collaborator Author

zr-msft commented Sep 29, 2023

@FeynmanZhou mind talking a look so i can merge?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Nov 14, 2023
FeynmanZhou
FeynmanZhou approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit abd80bc into notaryproject:main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yizha1 yizha1 yizha1 approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zr-msft @FeynmanZhou @yizha1