Change NIP-04 direct message and encryption naming to avoid ambiguity with NIP-17 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
May 21, 2024
tyiu
force-pushed
the
tyiu/change-nip04-naming
branch
from
b62716c to
32325aa
Compare
bryanmontz
requested changes
May 28, 2024
bryanmontz
approved these changes
May 28, 2024
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two NIPs overload the term "direct message", so we need to use the term "legacy" for the old one to differentiate them.
NIP-04 - Encrypted Direct Messages
NIP-17 - Private Direct Messages
Note that this PR contains breaking changes.