Replace Sodium with CryptoSwift #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiu
commented
Apr 5, 2024
bryanmontz
approved these changes
Apr 5, 2024
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Sodium, which is backed by a C library, broke documentation generation for some reason. We were using it for theChaCha20cipher for NIP-44 encryption, introduced in this commit: f1384b7This PR replaces
SodiumwithCryptoSwift, a pure Swift library, which implements the ChaCha20 cipher and seems to fix documentation generation. I tried it both locally and on themainremote branch on my fork.The fact that
NIP44v2EncryptingTestspasses gives me confidence that theCryptoSwiftusage is functionally equivalent to what we were doing withSodium.