Break out chat and threads from nip 29 #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 19, 2024 20:51
staab
force-pushed
the
relay-chat-2
branch
3 times, most recently
from
4bf12cb
to
336f5eb
Compare
|
Just updated this to only move kind 9 and 11 out of NIP 29. |
fiatjaf
reviewed
Nov 20, 2024
fiatjaf
reviewed
Nov 20, 2024
fiatjaf
approved these changes
Nov 20, 2024
|
Please remember to squash instead of merging. |
|
Are NIPs hex now? holy fuck |
Hex, or base36, or who knows? FWIW, adding letters breaks the auto-link regexp for NIP-XX for at least nostrudel, not a big deal but it'd be kind of useful to know what to expect, so we can be prepared when say NIP-🐙🦑 is added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of #1589 which attempts to reconcile NIP 29 and flotilla's rooms over chat and thread kinds. This requires no changes of NIP 29 clients, only flotilla will need to be modified.
I originally chose new event kinds in order to avoid stepping on anyone's toes, but it would be good if we can reconcile the two. One thing that is important to me for the semantics of chat/threads is that arbitrary reply hierarchies need not be supported. If NIP 29 folks are ok with the "shallow reply hierarchies" stipulation, then we can go ahead with this.