Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mailchimp sync screen #1633

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gloriateodoro
Copy link
Contributor

@gloriateodoro gloriateodoro commented Jul 12, 2022

  • inserir aba sincronizar nas configurações da widget para sincronizar os contatos da widget com o Mailchimp.

  • Inserir em todos os tipos de widget (formulario, pressao, doação).

  • Se não houver uma conta do mailchimp integrada à comunidade, o botão aparece desativado.

  • Quando clicar em sincronizar, deve exibir o status da sinronização assim omo ocorre nas configurações da comunidade

@gloriateodoro gloriateodoro requested review from lpirola, igr-santos and dieh and removed request for lpirola July 12, 2022 12:53
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1633 (887d94f) into main (a0493c9) will decrease coverage by 0.22%.
The diff coverage is 31.64%.

@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   65.65%   65.43%   -0.23%     
==========================================
  Files         776      779       +3     
  Lines       11790    11872      +82     
  Branches      845      869      +24     
==========================================
+ Hits         7741     7768      +27     
- Misses       3907     3962      +55     
  Partials      142      142              
Flag Coverage Δ
unittests 65.43% <31.64%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/__plugins__/donation/components/settings-menu.js 60.00% <0.00%> (-4.29%) ⬇️
...widgets/components/mailchimpSync/MailchimpIcon.tsx 66.66% <ø> (ø)
...ent/src/mobrender/widgets/adjustments/component.js 72.72% <ø> (ø)
...ient/src/mobilizations/widgets/components/Sync.tsx 23.40% <23.40%> (ø)
.../widgets/components/mailchimpSync/SettingsForm.tsx 37.03% <37.03%> (ø)
...obilizations/widgets/__plugins__/donation/paths.js 100.00% <100.00%> (ø)
...dgets/__plugins__/form/components/settings-menu.js 100.00% <100.00%> (ø)
...rc/mobilizations/widgets/__plugins__/form/paths.js 100.00% <100.00%> (ø)
...ient/src/mobilizations/widgets/components/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0493c9...887d94f. Read the comment docs.

const toast = useToast()

const community: any = useContext(SessionContext);
console.log("COMMUNITY", community)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remover console.log

a.data?.resync_mailchimp_start.status === 'started to add contacts to the queue') {
toast({ title: `Ae! Sincronização em andamento.`, status: 'success', isClosable: true });
} else {
toast({ title: 'Ish! Ocorreu um erro, tente sincronizar novamente.', description: `Se o problema persistir, contacte o suporte. ${a.data?.resync_mailchimp_start.status}` });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O texto deveria "contate" ou "entre em contato com"


//TODO: MENSAGEM "PRECISA CONFIGURAR MAILCHIMP NA COMUNIDADE"
if (!context.community.mailchimp_api_key || !context.community.mailchimp_list_id) {
console.log("VERRRR", context.community.mailchimp_api_key, context.community.mailchimp_list_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gloriateodoro Remover console.log, isso aqui gerar um problema de segurança da informação

@gloriateodoro gloriateodoro force-pushed the feature/mailchimp-sync-screen branch from ed9747c to 887d94f Compare July 12, 2022 16:41
@gloriateodoro gloriateodoro temporarily deployed to staging July 12, 2022 16:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants