Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

School feedback #54

Merged
merged 15 commits into from
Sep 14, 2023
Merged

School feedback #54

merged 15 commits into from
Sep 14, 2023

Conversation

FreyJo
Copy link
Collaborator

@FreyJo FreyJo commented Sep 13, 2023 •
edited
Loading

  • fix simple simulation tests
  • fix use_fesd=False
  • fix casadi version for tests to 3.6.3
  • improve README

@apozharski apozharski self-requested a review September 14, 2023 10:04
FreyJo
FreyJo commented Sep 14, 2023
View reviewed changes
Copy link
Collaborator Author

@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the help Anton!
I summarized the changes in the description :)

@FreyJo FreyJo merged commit 4bc12bd into main Sep 14, 2023
3 checks passed
@FreyJo FreyJo deleted the school_feedback branch September 14, 2023 10:06
apozharski
apozharski approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@apozharski apozharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apozharski apozharski apozharski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FreyJo @apozharski