Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gravity state #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove gravity state #14

wants to merge 3 commits into from

Conversation

avsaase
Copy link
Contributor

@avsaase avsaase commented Sep 29, 2024

Closes #5

I looked at some other other implementations and they all used a constant gravity vector.

nordmoen
nordmoen requested changes Sep 30, 2024
View reviewed changes
Copy link
Owner

@nordmoen nordmoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I agree with the change. My only request would be that you also bump the version to 0.4.0 since this will be a breaking change.

badicsalex and others added 3 commits October 7, 2024 22:45
@badicsalex @avsaase
Remove gravity from the filter state
2d7dbaf 
It might need to be a parameter, but it is for sure not something to
estimate. It makes convergence harded and it is redundant with acceleration
bias determination.
@avsaase
Add gravity to builder
7ee95b7
@avsaase
Bump version
6fada96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordmoen nordmoen nordmoen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gravity shouldn't be a filter state variable
3 participants
@avsaase @nordmoen @badicsalex