Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] updated storage version. #1477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ismaelpuerto
Copy link

Explain the changes

  1. updated storage account to version 2

Issues: Fixed #xxx / Gap #xxx

  1. storage v1 is marked as legacy type from Microsoft

Testing Instructions:

  • Doc added/updated
  • Tests added

Signed-off-by: Ismael Puerto Freire <[email protected]>
@liranmauda
Copy link
Contributor

Hi @ismaelpuerto
Thank you for this PR.

While I couldn’t find any breaking changes between v1 and v2, I am not entirely certain that a general-purpose v1 account will be compatible with a general-purpose v2 type.

Before merging this PR, we must ensure with absolute certainty that it does not disrupt upgrades or workflows involving customers with general-purpose v1 accounts.

I suggest the following steps:

  1. Use a general-purpose v1 account to test a fresh installation with this change.
  2. Use a general-purpose v1 account with a working NooBaa setup to test an upgrade to NooBaa with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants