Fix replication policy deletion (#1325)

Signed-off-by: Ben <[email protected]>
noobaa · Mar 19, 2024 · fd48560 · fd48560
1 parent 6221ee6
commit fd48560
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/pkg/obc/provisioner.go b/pkg/obc/provisioner.go
@@ -701,18 +701,19 @@ func (r *BucketRequest) putBucketTagging() error {
 func PrepareReplicationParams(bucketName string, replicationPolicy string, update bool) (*nb.BucketReplicationParams, *nb.DeleteBucketReplicationParams, error) {
 
 	var replicationRules nb.ReplicationPolicy
-	err := json.Unmarshal([]byte(replicationPolicy), &replicationRules)
-	if err != nil {
-		return nil, nil, fmt.Errorf("PrepareReplicationParams: Failed to parse replication json %q: %v", replicationRules, err)
-	}
-	deleteReplicationParams := &nb.DeleteBucketReplicationParams{
-		Name: bucketName,
-	}
 
 	if replicationPolicy == "" && update {
+		deleteReplicationParams := &nb.DeleteBucketReplicationParams{
+			Name: bucketName,
+		}
 		return nil, deleteReplicationParams, nil
 	}
 
+	err := json.Unmarshal([]byte(replicationPolicy), &replicationRules)
+	if err != nil {
+		return nil, nil, fmt.Errorf("PrepareReplicationParams: Failed to parse replication json %q: %v", replicationRules, err)
+	}
+
 	replicationParams := &nb.BucketReplicationParams{
 		Name:              bucketName,
 		ReplicationPolicy: replicationRules,