NSFS | Replace ChunkFS with FileWriter #8577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-file-writer
branch
from
81817fe
to
1168f81
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-file-writer
branch
from
1168f81
to
94c3ef9
Compare
guymguym
reviewed
Dec 4, 2024
Comment on lines
+1569
to
+1572
| const md5_enabled = | ||
| config.NSFS_CALCULATE_MD5 || | ||
| this.force_md5_etag || | ||
| object_sdk?.requesting_account?.force_md5_etag; |
There was a problem hiding this comment.
better use _is_force_md5_enabled() - it probably didn't exist when I wrote this code
Comment on lines
+1583
to
+1585
| file_writer.on('error', err => dbg.error('namespace_fs._upload_stream: error occured on FileWriter: ', err)); | ||
| file_writer.on('finish', arg => dbg.error('namespace_fs._upload_stream: finish occured on stream FileWriter: ', arg)); | ||
| file_writer.on('close', arg => dbg.error('namespace_fs._upload_stream: close occured on stream FileWriter: ', arg)); |
There was a problem hiding this comment.
are these error prints attempts to debug the Transform stream issues? still needed?
Comment on lines
+114
to
+117
| for (const buf of buffers) { | ||
| // @ts-ignore | ||
| if (buf.buffer_pool_release_callback) buf.buffer_pool_release_callback(); | ||
| } |
There was a problem hiding this comment.
this was a special code I added to test the nodejs changes I proposed for incoming http buffer pooling.
we can remove it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: