NSFS | NC | add option to set account supplemental groups #8552
+304
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
force-pushed
the
suplemental-groups
branch
4 times, most recently
from
702fd42 to
9abd913
Compare
naveenpaul1
reviewed
Dec 4, 2024
romayalon
requested changes
Dec 4, 2024
src/cmd/manage_nsfs.js
Outdated
| @@ -338,6 +338,7 @@ async function fetch_account_data(action, user_input) { | |||
| distinguished_name: user_input.user, | |||
| uid: user_input.user ? undefined : user_input.uid, | |||
| gid: user_input.user ? undefined : user_input.gid, | |||
| supplemental_groups: _.isUndefined(user_input.supplemental_groups) ? undefined : String(user_input.supplemental_groups), | |||
There was a problem hiding this comment.
looks like supplemental_groups loading is missing in bucketspace_fs.read_account_by_access_key()
There was a problem hiding this comment.
seems like read_account_by_access_key gets the account from name, and just modify strings to be sensitiveStrings. do we need to do any modifications to supplemental groups? adding log there to print supplemental groups show the correct value
| @@ -197,6 +201,19 @@ function validate_boolean_string_value(value) { | |||
| return false; | |||
| } | |||
|
|
|||
| function validate_supplemental_groups(value) { | |||
| if (value && typeof value === 'string') { | |||
There was a problem hiding this comment.
need to add the same validation on account_server/accountspace_FS
CC: @shirady
There was a problem hiding this comment.
I'm not sure I understand - in which context do you want to add those validations?
nadavMiz
force-pushed
the
suplemental-groups
branch
10 times, most recently
from
50fd414 to
f2ee5e0
Compare
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
suplemental-groups
branch
from
f2ee5e0 to
6f7239b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #7274
Testing Instructions:
sudo npx jest test_nc_nsfs_account_cli.test.jssudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_access.js