Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further abstraction in ModelMethod #93

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

JosePizarro3
Copy link
Collaborator

@JosePizarro3 JosePizarro3 commented Jun 27, 2024

Here you have the changes. I took the opportunity and added model_method_ref to Outputs as well.

I think one reviewer is enough, but if any of you want (@ndaelman-hu @Bernadette-Mohr) let me know and I add you as reviewers.

Closes #92

@JosePizarro3 JosePizarro3 requested a review from JFRudzinski June 27, 2024 09:49
@JosePizarro3 JosePizarro3 linked an issue Jun 27, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9694408630

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 79.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/model_method.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/nomad_simulations/schema_packages/model_method.py 3 70.94%
Totals Coverage Status
Change from base Build 9663609101: 0.2%
Covered Lines: 1549
Relevant Lines: 1954

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9694436071

Details

  • 18 of 19 (94.74%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 79.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/model_method.py 8 9 88.89%
Totals Coverage Status
Change from base Build 9663609101: 0.2%
Covered Lines: 1549
Relevant Lines: 1954

💛 - Coveralls

Copy link
Collaborator

@JFRudzinski JFRudzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structure makes sense to me, fits perfectly with what I started creating for FFs before 👍

Just the one small question about the definition of parameters in general

@JosePizarro3 JosePizarro3 merged commit ceef830 into develop Jun 28, 2024
4 checks passed
@JosePizarro3 JosePizarro3 deleted the 92-further-abstraction-in-modelmethod branch June 28, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further abstraction in ModelMethod
3 participants