Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define n_atoms_per_unit_cell for TB model method #139

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Define n_atoms_per_unit_cell for TB model method #139

merged 2 commits into from
Sep 27, 2024

Conversation

JosePizarro3
Copy link
Collaborator

closes #138

@JosePizarro3 JosePizarro3 linked an issue Sep 27, 2024 that may be closed by this pull request
Define n_atoms_per_unit_cell for TB model method #138
Closed
@JosePizarro3 JosePizarro3 merged commit 0b6c6cd into develop Sep 27, 2024
7 checks passed
@JosePizarro3 JosePizarro3 deleted the 138-define-n_atoms_per_unit_cell-for-tb-model-method branch September 27, 2024 11:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11069904005

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 80.301%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/model_method.py 5 6 83.33%
Totals Coverage Status
Change from base Build 11036586040: -0.008%
Covered Lines: 2030
Relevant Lines: 2528
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define n_atoms_per_unit_cell for TB model method
2 participants
@JosePizarro3 @coveralls