Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 problematic parsing of traj files from ase #131

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ladinesa
Copy link
Collaborator

No description provided.

@ladinesa ladinesa linked an issue Sep 13, 2024 that may be closed by this pull request
@ladinesa ladinesa self-assigned this Sep 13, 2024
@ladinesa ladinesa marked this pull request as draft September 13, 2024 14:21
@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10904074784

Details

  • 111 of 132 (84.09%) changed or added relevant lines in 7 files are covered.
  • 131 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 88.094%

Changes Missing Coverage Covered Lines Changed/Added Lines %
atomisticparsers/asap/parser.py 17 19 89.47%
atomisticparsers/utils/parsers.py 89 108 82.41%
Files with Coverage Reduction New Missed Lines %
tests/test_gromacsparser.py 8 96.34%
atomisticparsers/gromacs/parser.py 123 78.92%
Totals Coverage Status
Change from base Build 10848707148: -0.08%
Covered Lines: 6252
Relevant Lines: 7097

💛 - Coveralls

@schumannj
Copy link
Collaborator

I have tested this branch with my trajectory files and it works well in getting the structure as well as energies and forces.

One potential issue I noticed, is that the name of the calculator, (in my case "vasp") is listed under method>force_field>model>
Screenshot 2024-11-11 171618

Not sure it there is a clear way to tell if it was originally from a force field calculation or DFT. The traj.files I have available from my own previous work also have a range of level of detail. So it would be difficult to extract something general.
For my own use case it is enough to have structures and energies for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problematic parsing of *.traj files from ase
3 participants