Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added behavior for a long press on image cells. And added podspec back in. #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

crspybits
Copy link

@crspybits crspybits commented Feb 24, 2019

The new member variable:

open var cellMainAction: CellMainAction? = .tapShowLargeImage

for NohanaImagePickerController allows a long press to be used to show the large images. In this case, a tap on the main part of the cell just changed the picked state.

I added this because in my case two different actions when tapping different parts of the cell seemed difficult for a user.

I've also added the Cocoapods podspec back in. Various people were wondering why it was removed (#101) and I needed it too.

Various people were wondering why. And I needed it too.
@crspybits crspybits changed the title Added behavior for a long press on image cells. Added behavior for a long press on image cells. And added podspec back in. Feb 24, 2019
@haranicle haranicle requested review from haranicle and rizumi and removed request for haranicle and rizumi April 30, 2019 11:10
@rizumi rizumi self-requested a review December 13, 2019 08:13
Copy link
Contributor

@rizumi rizumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late confirmation.
Please separate podfile modifications and create another pull request.

Thanks for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants